perf(rendering): eliminate O(N^2) bottleneck in fold indicator detection#1567
Merged
perf(rendering): eliminate O(N^2) bottleneck in fold indicator detection#1567
Conversation
Refactor fold indicator calculation to iterate only over visible ViewLines instead of performing redundant linear scans of the entire viewport byte buffer. This fixes 100% CPU usage when thousands of lines are hidden by a collapsed fold. - Add source_start_byte to ViewLine for efficient mapping. - Refactor fold_indicators_for_viewport to use visible lines. - Remove redundant O(N) byte_offset_of_line_in_bytes helper. - Update tests and remove unused folding helper functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor fold indicator calculation to iterate only over visible ViewLines instead of performing redundant linear scans of the entire viewport byte buffer. This fixes 100% CPU usage when thousands of lines are hidden by a collapsed fold.